RFR: JDK-8090647: Mnemonics : on windows we should cancel the underscore latch when an app loses focus. [v2]

Ajit Ghaisas aghaisas at openjdk.org
Thu Feb 16 11:51:36 UTC 2023


On Wed, 15 Feb 2023 22:24:41 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> This fix hides mnemonics when the Scene's Window loses focus.
>> 
>> Before integration, we need to make sure this is correct behavior for Mac and Linux as well. It is correct for Windows.
>> 
>> How to test:
>> 
>> - Create a control with a mnemonic
>> - Alt-tab to another window (mnemonics appear when alt is pressed)
>> 
>> Before:
>> - Window shows visible mnemonic still and reacts on them when returning
>> 
>> After:
>> - Window hides mnemonics when focus is lost and doesn't react on them when returning
>
> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add test to verify scene disables mnemonics on focus lost

Fix looks good to me!

-------------

Marked as reviewed by aghaisas (Reviewer).

PR: https://git.openjdk.org/jfx/pull/1030


More information about the openjfx-dev mailing list