RFR: 8090123: Items are no longer visible when collection is changed

[Karthik P K]

On Fri, 17 Feb 2023 14:19:15 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/ContextMenuContent.java line 827:
>> 
>>> 825: 
>>> 826:     boolean isDownArrowVisible() {
>>> 827:         return upArrow.isVisible();
>> 
>> Just to double-check, shouldn't this be `downArrow.isVisible()`?
>
> Yes it should be `downArrow.isVisible()`. I'll update the code.

While this is a simple change, I thought of adding more checks on the visibility of both up and down arrow in the test to avoid these types of error in code. I'm seeing a strange issue that, I'm getting failures when more than 4 `Assert.assertTrue/assertFalse` statements are added. I'll investigate more on this and then update the code.

-------------

PR: https://git.openjdk.org/jfx/pull/1039