RFR: JDK-8302355: Public API for Toolkit.canStartNestedEventLoop() [v2]

Marius Hanl mhanl at openjdk.org
Sat Feb 18 13:30:43 UTC 2023


On Thu, 16 Feb 2023 22:09:26 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8302355: checkFxUserThread(), adjusted javadoc accordingly. Added Tests
>
> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line 396:
> 
>> 394:     /**
>> 395:      * Indicates whether a nested event loop can be started from the current thread in the current state.
>> 396:      * Note that a nested event loop is not allowed outside an event handler.
> 
> I would either remove this sentence (probably cleanest), or else change it to a positive statement (say when it is allowed, not when it isn't) and also add that it's ok when called from a Runnable passed to `Platform.runLater`. Maybe something like this:
> 
> 
> A nested event loop can be started from an event handler or from a `Runnable` passed
> to `Platform.runLater(Runnable)`.

done.

-------------

PR: https://git.openjdk.org/jfx/pull/1031


More information about the openjfx-dev mailing list