RFR: 8173321: TableView: Click on right trough has no effect when cell height is higher than viewport height [v7]

JoachimSchriek duke at openjdk.org
Sat Feb 18 15:11:40 UTC 2023


On Fri, 17 Feb 2023 13:56:23 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> JoachimSchriek has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into master
>>  - Restore original VirtualFlow.java
>>  - Changes made following findings from review
>>  - Deleted trailing whitespace
>>  - Committed Test Case for [openjdk/jfx] 8173321: Click on trough has no
>>    effect when cell height > viewport (PR #985):
>>  - Replaces Tabs with Spaces
>>  - JDK-8173321: Click on trough has no effect when cell height > viewport
>>    height
>
> tests/system/src/test/java/test/robot/javafx/scene/tableview/TableViewClickOnTroughTest.java line 101:
> 
>> 99:         Util.sleep(1000); // Delay for table moving Scrollbar
>> 100:         double newPosition = verticalBar.getValue();
>> 101:         Assert.assertTrue("moveTroughTest failed", oldPosition != newPosition);
> 
> Suggestion: You might consider using `assertNotEquals` with a delta of, say, `0.1`.

Ok

-------------

PR: https://git.openjdk.org/jfx/pull/985


More information about the openjfx-dev mailing list