RFR: 8299595: Remove terminally deprecated JavaFX GTK 2 library [v5]

[Thiago Milczarek Sayao]

On Sun, 19 Feb 2023 22:11:09 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:

>> Simple PR to remove gtk2 library compilation and loading.
>
> Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unused option

java @build/run.args -cp ~/temp/swt-4.26/swt.jar -Djdk.gtk.version=2 -Djdk.gtk.verbose=true tests/manual/swt/FXCanvasMouseButtonEventsTest.java 
checking GTK version 3
found already loaded GTK library libgtk-3.so.0
using GTK library version 3 set libgtk-3.so.0
Glass GTK library to load is glassgtk3
loaded gdk_x11_display_set_window_scale
loaded g_settings_schema_source_get_default
loaded g_settings_schema_source_lookup
loaded g_settings_schema_has_key
found schema 'org.gnome.desktop.interface' and key 'scaling-factor'
loaded g_settings_schema_unref



java @build/run.args -cp ~/temp/swt-3.8/swt.jar -Djdk.gtk.version=2 -Djdk.gtk.verbose=true tests/manual/swt/FXCanvasMouseButtonEventsTest.java 
Gtk-Message: 19:08:35.939: Failed to load module "canberra-gtk-module"
WARNING: A command line option tried to enable the GTK 2 library
WARNING: The JavaFX GTK 2 library was removed. The option will be ignored.
checking GTK version 3
found already loaded unsupported GTK library libgtk-x11-2.0.so.0
Exception in thread "main" java.lang.ExceptionInInitializerError
	at FXCanvasMouseButtonEventsTest.main(FXCanvasMouseButtonEventsTest.java:58)
Caused by: java.lang.UnsupportedOperationException: Unable to load glass GTK library.
	at javafx.graphics at 21-internal/com.sun.glass.ui.gtk.GtkApplication.lambda$new$4(GtkApplication.java:171)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:318)
	at javafx.graphics at 21-internal/com.sun.glass.ui.gtk.GtkApplication.<init>(GtkApplication.java:158)
	at javafx.graphics at 21-internal/com.sun.glass.ui.gtk.GtkPlatformFactory.createApplication(GtkPlatformFactory.java:40)
	at javafx.graphics at 21-internal/com.sun.glass.ui.Application.run(Application.java:146)
	at javafx.graphics at 21-internal/com.sun.javafx.tk.quantum.QuantumToolkit.startup(QuantumToolkit.java:290)
	at javafx.graphics at 21-internal/com.sun.javafx.application.PlatformImpl.startup(PlatformImpl.java:292)
	at javafx.graphics at 21-internal/javafx.application.Platform.startup(Platform.java:113)
	at javafx.swt/javafx.embed.swt.FXCanvas.lambda$initFx$4(FXCanvas.java:355)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:399)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:460)
	at javafx.swt/javafx.embed.swt.FXCanvas.initFx(FXCanvas.java:354)
	at javafx.swt/javafx.embed.swt.FXCanvas.<clinit>(FXCanvas.java:271)
	at FXCanvasMouseButtonEventsTest.main(FXCanvasMouseButtonEventsTest.java:58)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
	at java.base/java.lang.reflect.Method.invoke(Method.java:578)
	at jdk.compiler/com.sun.tools.javac.launcher.Main.execute(Main.java:434)
	at jdk.compiler/com.sun.tools.javac.launcher.Main.run(Main.java:205)
	at jdk.compiler/com.sun.tools.javac.launcher.Main.main(Main.java:132)



java @build/run.args -Djdk.gtk.version=2 -Djdk.gtk.verbose=true -jar apps/samples/Ensemble8/dist/Ensemble8.jar 
WARNING: A command line option tried to enable the GTK 2 library
WARNING: The JavaFX GTK 2 library was removed. The option will be ignored.
checking GTK version 3
trying GTK library libgtk-3.so.0
using GTK library version 3 set libgtk-3.so.0
Glass GTK library to load is glassgtk3
loaded gdk_x11_display_set_window_scale
loaded g_settings_schema_source_get_default
loaded g_settings_schema_source_lookup
loaded g_settings_schema_has_key
found schema 'org.gnome.desktop.interface' and key 'scaling-factor'
loaded g_settings_schema_unref

-------------

PR: https://git.openjdk.org/jfx/pull/999