RFR: 8090123: Items are no longer visible when collection is changed [v2]

[Karthik P K]

On Mon, 20 Feb 2023 15:05:03 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:

> I verified the changes on macOS and Windows - on both platforms `testChoicBoxScrollOnCollectionChange` passes when it's run as the only test (with `--tests '*testChoicBoxScrollOnCollectionChange'` option) but fails when you run all system tests:
> 
> ```
> java.lang.AssertionError
> 	at org.junit.Assert.fail(Assert.java:87)
> 	at org.junit.Assert.assertTrue(Assert.java:42)
> 	at org.junit.Assert.assertTrue(Assert.java:53)
> 	at test.robot.javafx.scene.ChoiceBoxScrollUpOnCollectionChangeTest.testChoicBoxScrollOnCollectionChange(ChoiceBoxScrollUpOnCollectionChangeTest.java:131)
> 	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
> 	...
> ```

I couldn't reproduce this issue both in windows and mac. Could you please give more details on this.

> tests/system/src/test/java/test/robot/javafx/scene/ChoiceBoxScrollUpOnCollectionChangeTest.java line 119:
> 
>> 117: 
>> 118:     @Test
>> 119:     public void testChoicBoxScrollOnCollectionChange() throws Exception {
> 
> There's also a minor spelling error here (s/Choic/Choice)

Fixed typo

-------------

PR: https://git.openjdk.org/jfx/pull/1039