RFR: 8090123: Items are no longer visible when collection is changed [v3]

[Andy Goryachev]

On Tue, 21 Feb 2023 06:05:54 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> When a large number of items were scrolled in the `ChoiceBox`, the scrolled offset was carried forward when the list is replaced with small number of items. Hence the scroll up arrow was displayed with empty popup.
>> 
>> Changed code to scroll to top before popup display when content height of `ChoiceBox` is smaller than the scrolled offset.
>> 
>> Added system test to validate the fix.
>
> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Correctig typo in test name

tested the fix with the MonkeyTester, this particular PR fixes the issue in the ticket.

I did notice two other issues with ChoiceBox (both present in the master as well as the fix, so both of them are unrelated to this PR):

1. adding ~1000 items takes a long time (1-2 seconds and a beach ball on Mac)
2. changing the data set does not clear the selected item, in fact it remains selected even though it may not be present in the new data set.

Do we have JBS bugs logged for these issues?  Karthik, could you please take a look?

this PR LG.

-------------

Marked as reviewed by angorya (Committer).

PR: https://git.openjdk.org/jfx/pull/1039