RFR: 8090123: Items are no longer visible when collection is changed [v5]

[Karthik P K]

On Wed, 22 Feb 2023 17:35:08 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> tests/system/src/test/java/test/robot/javafx/scene/ChoiceBoxScrollUpOnCollectionChangeTest.java line 108:
>> 
>>> 106:     private void showChoiceBox() throws Exception {
>>> 107:         mouseClick(choiceBox.getLayoutX() + choiceBox.getWidth() / 2,
>>> 108:                     choiceBox.getLayoutY() + choiceBox.getHeight() / 2);
>> 
>> are these two lines slightly misaligned?
>> 
>> perhaps we could convert this to
>> double x = ...;
>> double y = ...;
>> mouseClick(x, y);
>> 
>> (there is a value in having one statement per line, in general)
>
>> are these two lines slightly misaligned?
>> 
> The second line is aligned at 6 tabs from the start of the line. Because of that it looks misaligned.
> 
>> perhaps we could convert this to double x = ...; double y = ...; mouseClick(x, y);
>> 
>> (there is a value in having one statement per line, in general)
> 
> Since there are no repeated function calls I didn't convert them to variables. Yes converting the long statements to variables would make it more readable. I will work on that.

Updated code

-------------

PR: https://git.openjdk.org/jfx/pull/1039