RFR: 8290866: Apple Color Emoji turns gray after JavaFX version 18
Andy Goryachev
angorya at openjdk.org
Fri Feb 24 19:01:25 UTC 2023
On Thu, 23 Feb 2023 20:43:29 GMT, Phil Race <prr at openjdk.org> wrote:
> This fix properly supports colour rendering of Emoji on macOS
>
>
> On other platforms the Emoji will be rendered as ordinary greyscale glyphs - if there is font
> support for the requested code point.
>
> A simple manual test is provided which uses a Text node, Label control
> and editable TextField control.
>
> Some highlights of the code
> - To determine if it is a color emoji glyph probe the 'sbix' font table which is what is used by Apple
> - Text runs now break at an Emoji glyph
> - The Emoji is retrieved as an BGRA image - ie 4 channel including alpha
> - It was necessary to retrieve the Emoji glyph bounds via a different CoreText API since
> the bounds that were being retrieved were wrong for the Emoji image - causing clipping
> - It was necessary to retrieve the Emoji code point advance via a CoreText API since
> the HMTX metrics were very wrong - causing overlapping glyphs
> - drawString checks if it is an Emoji run and redirects to a new drawColorGlyph method
> which draws the image as a texture
> - All 3 rendering pipelines have this support and have been verified on all 3 desktop platforms
"[\ud83c\uddfa\ud83c\udde6\u2764\ufe0f\ud83c\udfc1\ud83c\uddfa\ud83c\uddf8\ud83d\udd25\ud83e\udd8b\n\ud83d\ude00 \ud83d\ude03 \ud83d\ude04 \ud83d\ude01 \ud83d\ude06 \ud83d\ude05 \ud83e\udd23 \ud83d\ude02\n\ud83d\ude42 \ud83d\ude43 \ud83d\ude09 \ud83d\ude0a \ud83d\ude07]";
-------------
PR: https://git.openjdk.org/jfx/pull/1047
More information about the openjfx-dev
mailing list