RFR: 8299595: Remove terminally deprecated JavaFX GTK 2 library [v3]

[Johan Vos]

On Sun, 19 Feb 2023 22:17:04 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/GtkApplication.java line 62:
>> 
>>> 60: 
>>> 61:     private static final String GTK2_REMOVED_WARNING =
>>> 62:         "WARNING: The JavaFX GTK 2 library was removed.";
>> 
>> Maybe add something like: `, so this option will be ignored` to make it more clear?
>
> I've inserted it, but opted for a new sentence.

I would like to see an additional info message, e.g. "continuing using GTK 3 instead" or similar. It's already good that the new warning says that the provided option will be ignored, but the user doesn't know the consequences.
I do realize it is getting a bit verbose, but as a user, I think there is value in seeing the severity of a warning. Hence, if we can avoid leaving the user with an "Ok, so what now?" feeling, I would vote for that.

I would even repeat the exact command line option that caused this, so that users can look where this option was set.

-------------

PR: https://git.openjdk.org/jfx/pull/999