RFR: 8216507: StyleablePropertyFactory: example in class javadoc does not compile [v3]
Karthik P K
kpk at openjdk.org
Mon Jan 2 11:42:55 UTC 2023
On Fri, 23 Dec 2022 17:30:04 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> I think it is good to add unit test to test the example code. Only thing I'm looking at is that if the example changes in future, we need to make sure that corresponding `MyButton` class is updated in unit test.
>> Since the example code might not change frequently, we can add unit test.
>
> I agree, let's add a unit test, unless `StyleablePropertyFactoryTest` covers the same scenario.
Added unit test for the 3rd example in `StyleablePropertyFactoryTest`.
Unit test for 1st example is already covered as part of `myBoolean` property.
Since example 2 and 3 are similar except for the place where `createBooleanCssMetaData` method is called, added single test for this.
Please review the newly added unit test
-------------
PR: https://git.openjdk.org/jfx/pull/983
More information about the openjfx-dev
mailing list