RFR: 8231864: JavaFX Labels in Tab's VBox is not displayed until it is clicked [v2]

Lukasz Kostyra lkostyra at openjdk.org
Mon Jan 2 14:10:20 UTC 2023


> Creating a not-displayed node and then modifying its contents caused JFX to not consume its old dirty region and thus not update it. When such node was displayed, its old dirty region was used for drawing, which in some cases (ex. new content taking more space - a Label having more text as in bug request) caused it to clip.
> 
> Resolved by always unionizing dirty regions with new bounds when calculating Node's transformed bounds.
> 
> Change was tested on macOS and Windows 10 and does not affect any tests.

Lukasz Kostyra has updated the pull request incrementally with one additional commit since the last revision:

  NGNode: Change comment at dirty bounds update for clarification

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/978/files
  - new: https://git.openjdk.org/jfx/pull/978/files/1fa43f3b..f5348154

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=978&range=01
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=978&range=00-01

  Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jfx/pull/978.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/978/head:pull/978

PR: https://git.openjdk.org/jfx/pull/978


More information about the openjfx-dev mailing list