RFR: 8273379 - GTK3 stops sending key events during drag and drop [v9]

Kevin Rushforth kcr at openjdk.org
Wed Jan 4 00:19:55 UTC 2023


On Tue, 3 Jan 2023 23:29:13 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:

>> This PR fixes 8273379.
>> 
>> I reverted back to use GDK (from [8225571](https://bugs.openjdk.org/browse/JDK-8225571)) to handle the events. 
>> 
>> It may also fix [8280383](https://bugs.openjdk.org/browse/JDK-8280383).
>> 
>> There's also some cleaup.
>> 
>> The most changed part is that I had to move `process_events` to `glass_evloop`  because it's reused in glass_dnd.
>> 
>> To do general testing:
>> `java @build/run.args -jar apps/toys/DragDrop/dist/DragDrop.jar`
>
> Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Simplify DragView paint

This will need a lot of careful testing.

Can  you provide more information about why undoing the changes from [JDK-8225571](https://bugs.openjdk.org/browse/JDK-8225571) is the best approach? Also, have you tested that the various issues that were fixed by JDK-8225571 won't regress as a result?

-------------

PR: https://git.openjdk.org/jfx/pull/986


More information about the openjfx-dev mailing list