Integrated: 8209017: CheckBoxTreeCell: graphic on TreeItem not always showing
Nir Lisker
nlisker at openjdk.org
Wed Jan 4 14:33:06 UTC 2023
On Tue, 6 Dec 2022 20:10:16 GMT, Nir Lisker <nlisker at openjdk.org> wrote:
> A simple fix for the graphics of a `CheckBoxTreeCell` not showing after expand/collapse events. The graphics node needs to be released from the previous checkbox so that it doesn't serve as the graphics of more than one checkbox at once. If it does, only one checkbox (its skin) can actually use it as a scenegraph child, and it's not always the correct one.
>
> Added also a manual test app as I'm unsure about how to do an automatic test for this. The test app will be useful for later fixes, so I suggest adding it anyway. To test the fix, simply expand and collapse the root note repeatedly while it has a child. Before the fix the graphic will disappear after a few tries, after the fix it won't. You can test other hierarchies as well by adding children to the tree.
This pull request has now been integrated.
Changeset: 012fa16f
Author: Nir Lisker <nlisker at openjdk.org>
URL: https://git.openjdk.org/jfx/commit/012fa16faccaf9b6a1f56cd3b5450ab200bdec9c
Stats: 135 lines in 5 files changed: 134 ins; 0 del; 1 mod
8209017: CheckBoxTreeCell: graphic on TreeItem not always showing
Reviewed-by: jhendrikx, angorya, kcr
-------------
PR: https://git.openjdk.org/jfx/pull/970
More information about the openjfx-dev
mailing list