RFR: 8178368: Right and Center alignment of text field works incorrectly [v3]
Karthik P K
kpk at openjdk.org
Thu Jan 5 09:49:41 UTC 2023
> When Text width was more than TextField width, the logic to update `textTranslateX` in `updateCaretOff` method was causing the issue of unexpected behavior for Right and Center alignment.
>
> Made changes to update `textTranslateX` in `updateCaretOff` method only when text width is less than text field width i.e `delta` is positive.
> For both right and center alignments, the `textTranslateX` value calculated in `updateTextPos` method will be updated without any condition so that expected behavior is achieved for all scenarios of text width relative to text field width.
>
> Added unit tests to validate LEFT, CENTER and RIGHT alignments. RIGHT and CENTER alignment tests are expected to fail without the fix provided in this PR.
Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
Update comments
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/980/files
- new: https://git.openjdk.org/jfx/pull/980/files/337ad7ac..8c1cd0c2
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=980&range=02
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=980&range=01-02
Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod
Patch: https://git.openjdk.org/jfx/pull/980.diff
Fetch: git fetch https://git.openjdk.org/jfx pull/980/head:pull/980
PR: https://git.openjdk.org/jfx/pull/980
More information about the openjfx-dev
mailing list