RFR: 8298728: Cells in VirtualFlow jump after resizing [v2]

[Johan Vos]

On Tue, 3 Jan 2023 11:59:27 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> Johan Vos has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   move statements to new lines.
>>   Add another failing test, and a fix: when the cell that is positioned at the "current index"
>>   is resized, we also need to modify the offset (wich is calculated from the top of that cell
>>   to the start of the viewport).
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java line 2329:
> 
>> 2327:             getOrCreateCellSize(index - 1);
>> 2328:         }
>> 2329:         if (index < getCellCount() -1) {
> 
> Minor : Need a space after `-`

fixed

> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/VirtualFlowTest.java line 1473:
> 
>> 1471: 
>> 1472: 
>> 1473:         for (int i =0 ; i < heights.length; i++) {
> 
> Minor : Need a space after `=`

fixed

-------------

PR: https://git.openjdk.org/jfx/pull/974