RFR: 8293119: Additional constrained resize policies for Tree/TableView [v23]

[Andy Goryachev]

On Mon, 19 Dec 2022 13:08:29 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 77 commits:
>> 
>>  - Merge remote-tracking branch 'origin/master' into 8293119.constrained
>>  - 8293119: review comments
>>  - 8293119: abstract
>>  - 8293119: <p>
>>  - 8293119: review comments
>>  - Merge remote-tracking branch 'origin/master' into 8293119.constrained
>>  - Merge remote-tracking branch 'origin/master' into 8293119.constrained
>>  - 8293119: small delta
>>  - Merge remote-tracking branch 'origin/master' into 8293119.constrained
>>  - 8293119: pref
>>  - ... and 67 more: https://git.openjdk.org/jfx/compare/8763e8b0...8bdae30e
>
> This has baked well. I tested on macOS and it looks good.
> 
> I see warnings on command line while trying to run `ATableViewResizeTester.java`. While the first warning is expected, we should fix others.
> 
> -----------------------------------------------------------------
> `javafx/tester/ATableViewResizeTester.java:224: warning: [deprecation] CONSTRAINED_RESIZE_POLICY in TableView has been deprecated
>             return TableView.CONSTRAINED_RESIZE_POLICY;
>                             ^
> javafx/tester/ATableViewResizeTester.java:456: warning: [unchecked] unchecked cast
>             TableColumn<String,String> c = (TableColumn<String,String>)t.getColumns().remove(ix);
>                                                                                             ^
>   required: TableColumn<String,String>
>   found:    TableColumn<String,CAP#1>
>   where CAP#1 is a fresh type-variable:
>     CAP#1 extends Object from capture of ?
> javafx/tester/ATableViewResizeTester.java:467: warning: [unchecked] unchecked conversion
>         TableView<String> table = new TableView();
>                                   ^
>   required: TableView<String>
>   found:    TableView
> javafx/tester/ATableViewResizeTester.java:640: warning: [unchecked] unchecked conversion
>             List<? extends TableColumnBase<?,?>> visibleLeafColumns = rf.getTable().getVisibleLeafColumns();
>                                                                                                          ^
>   required: List<? extends TableColumnBase<?,?>>
>   found:    ObservableList
> javafx/tester/ATableViewResizeTester.java:646: warning: [unchecked] unchecked call to setColumnWidth(TableColumnBase<S,?>,double) as a member of the raw type ResizeFeaturesBase
>                 rf.setColumnWidth(c, w);
>                                  ^
>   where S is a type-variable:
>     S extends Object declared in class ResizeFeaturesBase
> 5 warnings
> `

@aghaisas could you take a final look at this please?

-------------

PR: https://git.openjdk.org/jfx/pull/897