RFR: 8298167: Opacity in WebView not working anymore [v2]
Kevin Rushforth
kcr at openjdk.org
Wed Jan 11 15:01:32 UTC 2023
On Wed, 11 Jan 2023 14:58:07 GMT, Jay Bhaskar <jbhaskar at openjdk.org> wrote:
>> Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>>
>> Fixed the opacity issue
>
> The patch looks ok, as [GraphicsContextJava.h] needs to inherit methods from GraphicsContext.h , the begin/endPlatformTransparencyLayers already modified in latest update. so it looks like there would not be conflict.
> @jaybhaskar Can you also take a look? This might cause a merge conflict with the in-progress WebKit 615.1 update, but since this is a very targeted patch, I expect it would be an easy conflict to resolve, if it does.
I did a quick test, and confirmed that this does fix the problem. I also confirmed that there will be no merge conflict with WebKit 615.1.
@wkia Would it be possible to provide a unit test that fails before and passes after this fix?
-------------
PR: https://git.openjdk.org/jfx/pull/992
More information about the openjfx-dev
mailing list