RFR: 8298167: Opacity in WebView not working anymore [v5]

Kevin Rushforth kcr at openjdk.org
Wed Jan 11 23:13:27 UTC 2023


On Wed, 11 Jan 2023 18:58:44 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

>> There was refactoring in WebKit's GraphicsContext class (nativecode) https://github.com/WebKit/WebKit/commit/1733b8bc3dff7595ab8e42561fc0f20a2b8fee63 
>> 
>> GraphicsContextJava's methods begin/endPlatformTransparencyLayers weren't adapted after GraphicsContext's refactoring integration into JFX. As the result, the methods were not invoked, so TransparencyLayer couldn't be added to a rendering queue.
>> 
>> Now the methods are fixed to be used properly in GraphicsContext inheritance chain.
>
> Roman Marchenko has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Renamed vars in OpacityTest

Looks good. I can confirm that the newly added test fails without the fix and passes with the fix. I ran a CI test build on all three platforms and it passes on all of them.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.org/jfx/pull/992


More information about the openjfx-dev mailing list