RFR: 8230833: LabeledSkinBase computes wrong height with ContentDisplay.GRAPHIC_ONLY

Karthik P K kpk at openjdk.org
Mon Jan 16 10:53:08 UTC 2023


Ignore text condition was not considered in `computePrefHeight` method while calculating the Label height.

Added `isIgnoreText` condition in `computePrefHeight` method while calculating Label height.

Tests are present for all the ContentDisplay types. Modified tests which were failing because of the new height value getting calculated.

-------------

Commit messages:
 - Label height issue fix

Changes: https://git.openjdk.org/jfx/pull/996/files
 Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=996&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8230833
  Stats: 31 lines in 2 files changed: 6 ins; 8 del; 17 mod
  Patch: https://git.openjdk.org/jfx/pull/996.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/996/head:pull/996

PR: https://git.openjdk.org/jfx/pull/996


More information about the openjfx-dev mailing list