RFR: 8299595: Remove terminally deprecated JavaFX GTK 2 library

[Kevin Rushforth]

On Tue, 17 Jan 2023 22:57:49 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:

> Simple PR to remove gtk2 library compilation and loading.

The changes are what I would expect. I left a few (fairly minor) inline comments. I haven't tested it yet.

.idea/misc.xml line 4:

> 2: <project version="4">
> 3:   <component name="ExternalStorageConfigurationManager" enabled="true" />
> 4:   <component name="FrameworkDetectionExcludesConfiguration">

This change is unrelated to this issue and should be reverted.

modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/GtkApplication.java line 27:

> 25: package com.sun.glass.ui.gtk;
> 26: 
> 27: import com.sun.glass.ui.*;

Please expand this into separate imports, rather than using a wildcard import.

modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/GtkApplication.java line 168:

> 166:         @SuppressWarnings("removal")
> 167:         boolean gtkVersionVerbose =
> 168:                 AccessController.doPrivileged((PrivilegedAction<Boolean>) () -> Boolean.getBoolean("jdk.gtk.verbose"));

Minor: Since you are not otherwise touching this block, it would be cleaner to revert this reformatting change.

-------------

PR: https://git.openjdk.org/jfx/pull/999