RFR: 8230833: LabeledSkinBase computes wrong height with ContentDisplay.GRAPHIC_ONLY [v2]
Karthik P K
kpk at openjdk.org
Wed Jan 18 06:56:57 UTC 2023
> Ignore text condition was not considered in `computePrefHeight` method while calculating the Label height.
>
> Added `isIgnoreText` condition in `computePrefHeight` method while calculating Label height.
>
> Tests are present for all the ContentDisplay types. Modified tests which were failing because of the new height value getting calculated.
Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
Use width while calling prefHeight method. Use graphicHeight instead of multiple calls to prefHeight
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/996/files
- new: https://git.openjdk.org/jfx/pull/996/files/f59f1992..c2a2afa6
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=996&range=01
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=996&range=00-01
Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod
Patch: https://git.openjdk.org/jfx/pull/996.diff
Fetch: git fetch https://git.openjdk.org/jfx pull/996/head:pull/996
PR: https://git.openjdk.org/jfx/pull/996
More information about the openjfx-dev
mailing list