RFR: 8290765: Remove parent disabled/treeVisible listeners [v4]
Michael Strauß
mstrauss at openjdk.org
Sat Jan 28 16:24:30 UTC 2023
> `Node` adds InvalidationListeners to its parent's `disabled` and `treeVisible` properties and calls its own `updateDisabled()` and `updateTreeVisible(boolean)` methods when the property values change.
>
> These listeners are not required, since `Node` can easily call the `updateDisabled()` and `updateTreeVisible(boolean)` methods on its children, saving the memory cost of maintaining listeners and bindings.
Michael Strauß has updated the pull request incrementally with one additional commit since the last revision:
Initialize treeVisible field directly
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/841/files
- new: https://git.openjdk.org/jfx/pull/841/files/fe803883..02577bba
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=841&range=03
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=841&range=02-03
Stats: 50 lines in 3 files changed: 1 ins; 26 del; 23 mod
Patch: https://git.openjdk.org/jfx/pull/841.diff
Fetch: git fetch https://git.openjdk.org/jfx pull/841/head:pull/841
PR: https://git.openjdk.org/jfx/pull/841
More information about the openjfx-dev
mailing list