RFR: 8299753: Tree/TableView: Column Resizing With Fractional Scale [v4]

Andy Goryachev angorya at openjdk.org
Wed Jul 5 19:30:21 UTC 2023


> Modified the resize algorithm to work well with fractional scale, thanks for deeper understanding of the problem thanks to  @hjohn and @mstr2 .
> 
> It is important to note that even though the constraints are given by the user in unsnapped coordinates, they are converted to snapped values, since the snapped values correspond to the actual pixels on the display.  This means the tests that validate honoring constraints should, in all the cases where (scale != 1.0), assume possibly error not exceeding (1.0 / scale) (I think).

Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:

 - whitespace
 - Merge remote-tracking branch 'origin/master' into 8299753.resize
 - review comments
 - review comments
 - whitespace
 - removed obsolete tester
 - Merge remote-tracking branch 'origin/master' into 8299753.resize
 - cleanup
 - new algorithm

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1156/files
  - new: https://git.openjdk.org/jfx/pull/1156/files/2e06578e..908203cd

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1156&range=03
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1156&range=02-03

  Stats: 6565 lines in 125 files changed: 3405 ins; 2951 del; 209 mod
  Patch: https://git.openjdk.org/jfx/pull/1156.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1156/head:pull/1156

PR: https://git.openjdk.org/jfx/pull/1156


More information about the openjfx-dev mailing list