RFR: 8299753: Tree/TableView: Column Resizing With Fractional Scale [v4]

[Andy Goryachev]

On Wed, 5 Jul 2023 20:31:09 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - whitespace
>>  - Merge remote-tracking branch 'origin/master' into 8299753.resize
>>  - review comments
>>  - review comments
>>  - whitespace
>>  - removed obsolete tester
>>  - Merge remote-tracking branch 'origin/master' into 8299753.resize
>>  - cleanup
>>  - new algorithm
>
> I agree with John that a layout algorithm that uses incremental calculations will always be flawed in principle. The correct approach is to store the initial configuration, and then for each configuration change, go back to the initial configuration and recompute the layout solution.
> 
> Now, we might still accept a bugfix for a flawed algorithm. But JDK-8299753 is an enhancement, not a bugfix. I'm not sure what to make of this: it's obviously a flawed approach, and basing an enhancement on a flawed approach means that someone would have to come back to this issue in the future and solve it correctly.
> 
> I don't think that the issue at hand is so severe that it's a forced move to integrate this interim solution.

I respectfully disagree, @mstr2 .

This fix is not an interim solution - unlike any theoretical considerations of "flawed approach", in practice this code does work as expected with integer and fractional scales, and, given our situation, it's highly unlikely that any alternative solutions will ever be considered, especially those that would affect existing public APIs.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1156#issuecomment-1622464854