RFR: 8242419: JFXPanel: MouseEvent always reports that Primary button changed state if held [v2]

Prasanta Sadhukhan psadhukhan at openjdk.org
Thu Jul 6 03:21:19 UTC 2023


On Wed, 5 Jul 2023 19:28:37 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix comment
>
> modules/javafx.swing/src/main/java/com/sun/javafx/embed/swing/SwingEvents.java line 84:
> 
>> 82:         }
>> 83:         // Fix for RT-15457: we should report mouse buttons for mouse drags
>> 84:         if (abstractButton == AbstractEvents.MOUSEEVENT_NONE_BUTTON) {
> 
> minor: the placement of the old comment suggests that it applies to like 84 (this change).  Perhaps the comment should be moved down to the line 85.

ok..done..

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1170#discussion_r1253875203


More information about the openjfx-dev mailing list