RFR: 8274932: Render scales in EmbeddedWindow are not properly updated [v2]

Andy Goryachev angorya at openjdk.org
Fri Jul 7 17:13:24 UTC 2023


On Fri, 7 Jul 2023 17:07:57 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> When the JavaFX scene is set before it is really shown, then the scale factors are not properly propagated to the EmbeddedWindow, resulting in showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasanta Sadhukhan has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Set stage scale in FX thread
>  - Set stage scale in FX thread

modules/javafx.swing/src/main/java/javafx/embed/swing/JFXPanel.java line 644:

> 642:                    stage.setRenderScaleY(scaleFactorY);
> 643:                 }
> 644:             });

[question]
could there be race condition between sendResizeEventToFX() and stage.setRenderScale() since we now have two different threads operating?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1171#discussion_r1256148933


More information about the openjfx-dev mailing list