RFR: 8285700: [TreeTableView] graphic property of TreeItem is still visible after collapsing tree

Johan Vos jvos at openjdk.org
Sun Jul 9 08:02:02 UTC 2023


On Sat, 8 Jul 2023 10:15:47 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> In `TreeTableRowSkin`, graphic was not updated along with tree item update.
>> 
>> Made changes to update graphics of TreeTableView row in `updateTreeItem()` method.
>> 
>> Added options in monkey tester to add graphics and subnodes to `TreeTableView` rows.
>
> Is it possible to write a Unit test as well?

+1 on @Maran23 to add a unit test.
For these kinds of changes, I think it is important to have a performance check as well (e.g. count the number of invocations to updateItem etc).

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1172#issuecomment-1627640393


More information about the openjfx-dev mailing list