RFR: 8274932: Render scales in EmbeddedWindow are not properly updated [v5]

Andy Goryachev angorya at openjdk.org
Mon Jul 10 16:22:14 UTC 2023


On Mon, 10 Jul 2023 06:54:49 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> When the JavaFX scene is set before it is really shown, then the scale factors are not properly propagated to the EmbeddedWindow, resulting in showing wrong scales.
>> Fix is made to update scales to EmbeddedWindow
>
> Prasanta Sadhukhan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Merge branch 'master' of https://github.com/openjdk/jfx into JDK-8274932
>  - Fix to get correct scale in secondary monitor
>  - Set stage scale in FX thread
>  - Set stage scale in FX thread
>  - Set stage scale in FX thread
>  - 8274932: Render scales in EmbeddedWindow are not properly updated

getting the scales right on both monitors now (macOS)
the image is rendered with no gaps.
LGTM

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/1171#pullrequestreview-1522452579


More information about the openjfx-dev mailing list