RFR: 8311806: Class ButtonAccessibility is implemented twice

Tue Jul 11 20:15:11 UTC 2023

On Mon, 10 Jul 2023 20:39:34 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

> To avoid confusion on the os x dynamic linker side i renamed native classes from ButtonAccessibility to JFXButtonAccessibility. I will use JFX prefix down the line to avoid any confusion when running with the latest JDK that also migrated to the new a11y API.

The fix looks fine and should avoid the problem of name collision. It seems unfortunate that the namespace is global, especially in this case, since the symbols are not needed outside of libglass.dylib. Is there a way to hide the symbols so that they are not exported? If not, then adopting the pattern you chose is OK.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1174#issuecomment-1631448738