RFR: JDK-8304439: Subscription based listeners [v12]

[Kevin Rushforth]

On Tue, 11 Jul 2023 23:19:21 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> Makes `Subscription` public (removing some of its methods that are unnecessary), and adds methods that can provide `Subscription`s in `ObservableValue`.
>
> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix subscriber -> valueSubscriber

I left one comment on one of the tests. Presuming it should be changed, you can either do it now (and I'll reapprove) or file a follow-up test bug.

Please wait until tomorrow (ideally, before 1600 UTC to be ahead of the RDP1 fork) to integrate this in order to give @johanvos @jperedadnr or @nlisker a chance to comment.

modules/javafx.base/src/test/java/test/javafx/beans/ObservableSubscriptionsTest.java line 68:

> 66: 
> 67:         value.get();
> 68:         value.set("C");

Should this be a different value from the previously set one to ensure that an invalidation listener would get called if it were still subscribed?

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1069#pullrequestreview-1527323433
PR Review Comment: https://git.openjdk.org/jfx/pull/1069#discussion_r1261787469