RFR: 8285700: [TreeTableView] graphic property of TreeItem is still visible after collapsing tree [v2]
Karthik P K
kpk at openjdk.org
Mon Jul 17 07:09:09 UTC 2023
On Fri, 14 Jul 2023 16:00:33 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
>> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add unit test
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TreeTableRowSkinTest.java line 407:
>
>> 405:
>> 406: @AfterEach
>> 407: public void after() {
>
> unrelated to the current PR, but could this method be more defensive, to avoid any problems with the invocation order?
>
>
> @AfterEach
> public void after() {
> if (stageLoader != null) {
> stageLoader.dispose();
> stageLoader = null;
> }
> }
This looks like a good check to have.
Made above suggested code changes.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1172#discussion_r1264954990
More information about the openjfx-dev
mailing list