RFR: JDK-8310681: Update WebKit to 616.1
Jay Bhaskar
jbhaskar at openjdk.org
Mon Jul 24 02:52:47 UTC 2023
On Sun, 23 Jul 2023 15:55:39 GMT, Johan Vos <jvos at openjdk.org> wrote:
> > Oh, I see that now. What led me to ask this question was that there is an alternative implementation in `#if PLATFORM(JAVA)`, which implies that we removed the call to `stripLeadingAndTrailingHTMLSpaces` and that it is still present in the upstream.
> > Given that this code block now matches the upstream, the `if..else..endif` block should simply be replaced with:
> > ```
> > return document().completeURL(linkAttribute);
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > removing the `#if PLATFORM(JAVA)` and the entire `#else` block (including the old call to `stripLeadingAndTrailingHTMLSpaces`). Otherwise it will be confusing and possibly lead to merge conflicts later.
>
> I agree with this. Is there a reason this can't be done in the current PR?
I agree, we will apply the suggestion.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1180#issuecomment-1647119576
More information about the openjfx-dev
mailing list