RFR: 8255248: NullPointerException in JFXPanel due to race condition in HostContainer [v3]

Prasanta Sadhukhan psadhukhan at openjdk.org
Mon Jul 24 07:02:03 UTC 2023


On Fri, 21 Jul 2023 21:30:08 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> tests/system/src/test/java/test/javafx/embed/swing/JFXPanelNPETest.java line 98:
>> 
>>> 96:         });
>>> 97:         SwingUtilities.invokeAndWait(JFXPanelNPETest::createUI);
>>> 98:         for (int i = 0; i < 300; i++) {
>> 
>> I think this is way too long for a unit test.  300 iterations, 200 ms each = 60 seconds
>
> good point!
> 
> at the same time, we probably want to cover both extremes (short and long delays).
> what would be a reasonable upper limit for a test?  10 seconds?

It used to be 3000 for JBS reproducer which I reduced to 300 for consistent issue reproduction, below which the issue might not be seen so consistently even without the fix and I guess the test is supposed to fail without the fix and pass with it..

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1178#discussion_r1271828106


More information about the openjfx-dev mailing list