RFR: 8313227: Correct attenuation indicator for removed lights

Kevin Rushforth kcr at openjdk.org
Thu Jul 27 22:10:51 UTC 2023


On Thu, 27 Jul 2023 03:44:56 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

> @kevinrushforth I think that this is simple enough to be able to get into RDP1. There is some performance improvement regained here that was lost in one of my previous enhancements because of my mistake of setting this parameter to 1.
> 
> I think that 1 reviewer is enough.

Yes, I agree that a single reviewer should be fine. This seems a reasonable candidate to backport to `jfx21` during RDP1 (no approval beyond the code review of the backport is needed).

> By the way, the lighting in the LightingSample test application looks a bit off to me (regardless of this patch). It's as if the point and spot lights are too dim even at close range. Do you also notice that? Might need to look at previous revisions to see when it started,

I'll take a quick look on both Mac and Windows and let you know what I find.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1186#issuecomment-1654647647


More information about the openjfx-dev mailing list