RFR: 8299756: Minor updates in CSS Reference [v3]

[John Hendrikx]

On Wed, 31 May 2023 23:14:21 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Minor fixes and addition of missing sections:
>> 
>> - The 'system' font is missing from the list of generic font family names in the <font> section. ✓
>> - Explicitly add text color property -fx-fill to Text section, so as not to confuse with Labeled -fx-text-fill ✓
>> - TextFlow section is missing, properties: -fx-text-alignment, -fx-line-spacing, -fx-tab-size ✓
>> - Text: missing -fx-line-spacing, -fx-bounds-type ✓
>> - -fx-focus-traversable is in Node and not in Control (though there is some relevant comment) - keep as is. ✓
>> - Node: broken link to 'Control' (sic, not Controls) in "... see Controls for details" ✓
>> - Missing <text-bounds-type> type ✓
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   pane

Marked as reviewed by jhendrikx (Committer).

modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line 1598:

> 1596:     <ul>
> 1597:       <li><strong>logical</strong>: The logical bounds are based on font metrics information.
> 1598:           The width is based on the glyph advances and the height on the ascent, descent, and

Should this perhaps be "of" ?
Suggestion:

          The width is based on the glyph advances and the height of the ascent, descent, and

modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line 1599:

> 1597:       <li><strong>logical</strong>: The logical bounds are based on font metrics information.
> 1598:           The width is based on the glyph advances and the height on the ascent, descent, and
> 1599:           line gap. Except for the last line which does not include the line gap.

I think this may flow better:
Suggestion:

          line gap, except for the last line which does not include the line gap.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1144#pullrequestreview-1454348384
PR Review Comment: https://git.openjdk.org/jfx/pull/1144#discussion_r1212431893
PR Review Comment: https://git.openjdk.org/jfx/pull/1144#discussion_r1212432358