RFR: 8308308: Update to Visual Studio 2022 version 17.5.0 on Windows [v2]

Joeri Sykora sykora at openjdk.org
Thu Jun 1 15:00:18 UTC 2023


On Tue, 30 May 2023 19:10:08 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Update the compiler on Windows to Visual Studio 2022 17.5.0. This provides the needed C++20 support for the next WebKit update.
>> 
>> On Windows, the existing WebKit 615.1 build fails with Visual Studio 2022 17.5.0 -- see [JDK-8303748](https://bugs.openjdk.org/browse/JDK-8303748). The solution for the failure is to compile 615.1 using the C++20 flag for Windows (we will use this flag on all platforms for the next WebKit update). The fix for that bug is necessarily included in this PR, since the two fixes as interdependent.
>
> Kevin Rushforth has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - Merge remote-tracking branch 'upstream/master' into 8308308-vs2022-17.5.0
>  - 8308308: Update to Visual Studio 2022 version 17.5.0 on Windows
>  - enable c++20 for windows and c++17 for other platforms

We still used an older version of cmake and updating it to 3.22.3 fixed the issue. Everything works fine now.

-------------

Marked as reviewed by sykora (Author).

PR Review: https://git.openjdk.org/jfx/pull/1142#pullrequestreview-1455691681


More information about the openjfx-dev mailing list