RFR: 8299756: Minor updates in CSS Reference [v4]

Kevin Rushforth kcr at openjdk.org
Thu Jun 1 16:34:13 UTC 2023


On Thu, 1 Jun 2023 15:50:37 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Minor fixes and addition of missing sections:
>> 
>> - The 'system' font is missing from the list of generic font family names in the <font> section. ✓
>> - Explicitly add text color property -fx-fill to Text section, so as not to confuse with Labeled -fx-text-fill ✓
>> - TextFlow section is missing, properties: -fx-text-alignment, -fx-line-spacing, -fx-tab-size ✓
>> - Text: missing -fx-line-spacing, -fx-bounds-type ✓
>> - -fx-focus-traversable is in Node and not in Control (though there is some relevant comment) - keep as is. ✓
>> - Node: broken link to 'Control' (sic, not Controls) in "... see Controls for details" ✓
>> - Missing <text-bounds-type> type ✓
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   controls

Looks good.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1144#pullrequestreview-1455883170


More information about the openjfx-dev mailing list