RFR: 8306447: Adding an element to a long existing list may cause the first visible element to jump [v2]
Kevin Rushforth
kcr at openjdk.org
Fri Jun 2 11:28:16 UTC 2023
On Sat, 29 Apr 2023 20:05:52 GMT, Johan Vos <jvos at openjdk.org> wrote:
>> Calculate position of first visible element before propagating changes.
>> Make sure to restore the position of said element after the changes are done.
>>
>> Fix JDK-8306447
>
> Johan Vos has updated the pull request incrementally with one additional commit since the last revision:
>
> Make sure not to change index and offset when the cell count change.
> Use the old cellcount when doing initial calculations, as the estimated
> cell size will otherwise be wrong.
>
> Extend the testcase for this, by adding 9 cells instead of just 1
Looks good.
-------------
Marked as reviewed by kcr (Lead).
PR Review: https://git.openjdk.org/jfx/pull/1099#pullrequestreview-1457164833
More information about the openjfx-dev
mailing list