RFR: 8293836: Rendering performance degradation at bottom of TableView with many rows [v2]

[Marius Hanl]

On Thu, 1 Jun 2023 20:30:06 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> Johan Vos has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   remove newline
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java line 3083:
> 
>> 3081:         if (itemSizeCache.size() > cellIndex) {
>> 3082:             Double oldSize = itemSizeCache.get(cellIndex);
>> 3083:             double newSize = isVertical() ? cell.getLayoutBounds().getHeight() : cell.getLayoutBounds().getWidth();
> 
> If we have a fixed cell size set, can we save the call to get the layout bounds here?
> Since this is also done above in `getOrCreateCellSize` (`getFixedCellSize()`).
> And the layout bounds are calculated lazily, so this may improve the performance here as well.

@johanvos I still think this should be evaluated.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1098#discussion_r1214378282