RFR: 8306121: Scene not rendered initially when changing scenes after fix for JDK-8296621 [v18]
Kevin Rushforth
kcr at openjdk.org
Mon Jun 5 22:53:04 UTC 2023
On Sun, 4 Jun 2023 18:48:29 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:
>> I replicated the fix on #1054 on Linux.
>>
>> Also fixes [Monocle: Stage no longer gets focus after fix for JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734)
>
> Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
>
> Unchanged line
I ran an automated test job using your latest patch and all of the tests now pass.
> Maybe it's possible to do a Java fix where the new Scene without size inherits the old Scene size? This way I think it possible to remove platform specific code such as the one I did and `_updateViewSize`.
Hmm. That might be problematic. In any case, I don't want to go down that route to fix this bug.
I have two questions on the current version of the fix:
1. Can you explain why the two tests had to be changed? Unless the tests in question really were buggy, and just getting luck before, the changes suggest a change in behavior that applications might notice and be bothered by.
2. Are you sure that on Linux, there are no cases where `_updateViewSize` needs to be implemented? Did you consider just leaving it as-is or would that have failed?
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1110#issuecomment-1577582572
More information about the openjfx-dev
mailing list