RFR: 8304290: Some JNI calls made without checking exceptions in media [v2]

[Alexander Matveev]

On Mon, 5 Jun 2023 21:04:15 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8304290: Some JNI calls made without checking exceptions in media [v2]
>
> modules/javafx.media/src/main/native/jfxmedia/jni/JniUtils.cpp line 59:
> 
>> 57:             }
>> 58:             // This shouldn't happen...
>> 59:             return;
> 
> Don't you still need this `return`?

I moved it under `if (env->ExceptionCheck() || klass != NULL)`, but this check is incorrect and it should be `if (env->ExceptionCheck() || klass == NULL)`. I fixed it.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1094#discussion_r1220523650