RFR: 8309470: Potential performance improvements in VirtualFlow
Andy Goryachev
angorya at openjdk.org
Thu Jun 8 00:09:54 UTC 2023
On Wed, 7 Jun 2023 20:59:01 GMT, Marius Hanl <mhanl at openjdk.org> wrote:
> This PR does two small improvements to `VirtualFlow`.
> Until now, the `VirtualFlow` sometimes called the `computeHeight` or `computeWidth` methods, although a fixed cell size is set and we therefore don't need to call those method (and never should do, as we may don't get the expected result and mix computed sizes with the fixed cell size).
>
> Added tests that fail before and pass now. They check that the `computeHeight` or `computeWidth` (non vertical flow) are never called when a fixed cell size is set.
I don't see any ill effects in the MonkeyTester.
There is still a bit of lag with 10,000,000 row model, same as before.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1150#issuecomment-1581676505
More information about the openjfx-dev
mailing list