RFR: 8309470: Potential performance improvements in VirtualFlow [v3]

Andy Goryachev angorya at openjdk.org
Thu Jun 8 15:26:56 UTC 2023


On Thu, 8 Jun 2023 07:18:22 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> This PR does two small improvements to `VirtualFlow`.
>> Until now, the `VirtualFlow` sometimes called the `computeHeight` or `computeWidth` methods, although a fixed cell size is set and we therefore don't need to call those method (and never should do, as we may don't get the expected result and mix computed sizes with the fixed cell size).
>> 
>> Added tests that fail before and pass now. They check that the `computeHeight` or `computeWidth` (non vertical flow) are never called when a fixed cell size is set.
>
> Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK-8309470: Improved Tests

Strange, I don't see failures in VirtualFlowTest on macOS 13.3.1(a) in Eclipse.
@karthikpandelu could you make sure you have no modified files in the repository and try doing a full build?

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1150#issuecomment-1582814294


More information about the openjfx-dev mailing list