RFR: 8309470: Potential performance improvements in VirtualFlow [v4]
Marius Hanl
mhanl at openjdk.org
Thu Jun 8 15:51:07 UTC 2023
> This PR does two small improvements to `VirtualFlow`.
> Until now, the `VirtualFlow` sometimes called the `computeHeight` or `computeWidth` methods, although a fixed cell size is set and we therefore don't need to call those method (and never should do, as we may don't get the expected result and mix computed sizes with the fixed cell size).
>
> Added tests that fail before and pass now. They check that the `computeHeight` or `computeWidth` (non vertical flow) are never called when a fixed cell size is set.
Marius Hanl has updated the pull request incrementally with one additional commit since the last revision:
JDK-8309470: Remove unused import and comment
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/1150/files
- new: https://git.openjdk.org/jfx/pull/1150/files/4527e652..486c7254
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=1150&range=03
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=1150&range=02-03
Stats: 2 lines in 2 files changed: 0 ins; 2 del; 0 mod
Patch: https://git.openjdk.org/jfx/pull/1150.diff
Fetch: git fetch https://git.openjdk.org/jfx.git pull/1150/head:pull/1150
PR: https://git.openjdk.org/jfx/pull/1150
More information about the openjfx-dev
mailing list