RFR: 8309470: Potential performance improvements in VirtualFlow [v3]

[Andy Goryachev]

On Thu, 8 Jun 2023 15:43:00 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/VirtualFlowTest.java line 1542:
>> 
>>> 1540:             @Override
>>> 1541:             protected double computeMinHeight(double width) {
>>> 1542:                 return 1337;
>> 
>> Can we add a final variable for this number since it is repeated many times?
>
> It is just an arbitrary number for testing and only used for those two methods.
> Not sure if it is worth it (it can be basically every number but should not be the fixed cell size)

yeah, I don't think it's that important.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1150#discussion_r1223232725