RFR: 8309508: Possible memory leak in JPEG image loader

Kevin Rushforth kcr at openjdk.org
Fri Jun 9 13:25:52 UTC 2023


On Fri, 9 Jun 2023 05:18:16 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

> On code inspection it is revealed that in jpegloader.c->decompressIndirect() we are allocating memory for "scanline_ptr", but if we error_exit() from jpeg_read_scanlines() we are not releasing this memory.
> 
> Added release of "scanline_ptr" with NULL check at appropriate places.
> As part of this fix also added RELEASE_ARRAYS() call for stream/pixel buffer in all cases where we move back to Java code.
> 
> Its difficult to create definite pass/fail regression test for memory leak, added noreg-hard label in JBS.

Looks good.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1151#pullrequestreview-1472058376


More information about the openjfx-dev mailing list