RFR: JDK-8199216: Memory leak and quadratic layout time with nested nodes (hbox) and pseudo-class in style sheet [v6]

John Hendrikx jhendrikx at openjdk.org
Sat Jun 10 00:10:52 UTC 2023


On Fri, 9 Jun 2023 22:11:10 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/com/sun/javafx/css/BitSet.java line 44:
>> 
>>> 42:  * which makes matching faster.
>>> 43:  */
>>> 44: abstract class BitSet<T> extends AbstractSet<T> implements ObservableSet<T> {
>> 
>> Since this is an internal class, would it be possible / make sense to rename it, to avoid confusion with the real Slim^H^H^H^H BitSet?  StyleBitSetBase or some such?
>
> BitSet name still bugs me.

Sure, but I think that would be out of scope for this PR.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1076#discussion_r1224906677


More information about the openjfx-dev mailing list