RFR: 8306121: Scene not rendered initially when changing scenes after fix for JDK-8296621 [v20]

[Jose Pereda]

On Tue, 6 Jun 2023 01:09:36 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:

>> I replicated the fix on #1054 on Linux.
>> 
>> Also fixes [Monocle: Stage no longer gets focus after fix for JDK-8296621](https://bugs.openjdk.org/browse/JDK-8304734)
>
> Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Insert copyright

Looks good
Tested on macOS and Linux (with known issue on macOS), and Android, so indeed https://bugs.openjdk.org/browse/JDK-8304476 can be closed as duplicated.

I haven't tested Monocle/TestFX though.

I have minor comments only.

modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/infrastructure/MouseEventFirerTest.java line 277:

> 275:         setLeftAnchor(bottomRight, 0.);
> 276: 
> 277:         content = new AnchorPane(center, topLeft, bottomRight);

update license header

modules/javafx.controls/src/test/java/test/javafx/scene/control/ComboBoxTest.java line 1131:

> 1129:         comboBox.requestFocus();
> 1130: 
> 1131:         var kFirer = new KeyEventFirer(comboBox);

update license header

modules/javafx.graphics/src/main/java/javafx/stage/Stage.java line 1192:

> 1190:             if (!isIconified()) {
> 1191:                 peer.requestFocus();
> 1192:             }

This works fine on Android.

modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 1327:

> 1325: void WindowContextTop::update_view_size() {
> 1326:     // Notify the view size only if size is oriented by WINDOW, otherwise
> 1327:     // it knows it's own size

minor: `s/it's/its`

tests/manual/stage/StartIconified.java line 37:

> 35:  * If the stage pops on the Screen and then iconifies, it's wrong.
> 36:  */
> 37: public class StartIconified extends Application {

Should we mention this doesn't work on macOS until https://bugs.openjdk.org/browse/JDK-8305675 gets fixed?

-------------

PR Review: https://git.openjdk.org/jfx/pull/1110#pullrequestreview-1479636142
PR Review Comment: https://git.openjdk.org/jfx/pull/1110#discussion_r1229760146
PR Review Comment: https://git.openjdk.org/jfx/pull/1110#discussion_r1229768464
PR Review Comment: https://git.openjdk.org/jfx/pull/1110#discussion_r1229778730
PR Review Comment: https://git.openjdk.org/jfx/pull/1110#discussion_r1229730263
PR Review Comment: https://git.openjdk.org/jfx/pull/1110#discussion_r1229790900