RFR: 8310024: Skip failing scene change tests on macOS

[Kevin Rushforth]

On Wed, 14 Jun 2023 15:35:40 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Simple fix to skip two failing tests on macOS until the underlying bugs are fixed:
>> 
>> SceneChangeEventsTest::testSceneChange -- [JDK-8300094](https://bugs.openjdk.org/browse/JDK-8300094)
>> SceneChangeShouldNotFocusStageTest::windowShouldRemainIconified -- [JDK-8305675](https://bugs.openjdk.org/browse/JDK-8305675)
>> 
>> With this patch, we now get a clean test run on macOS 12 and 13.
>
> tests/system/src/test/java/test/robot/javafx/scene/SceneChangeShouldNotFocusStageTest.java line 69:
> 
>> 67:     public static void exit() {
>> 68:         if (stage != null) {
>> 69:             Util.shutdown(stage);
> 
> I wonder if we should move the null check to Util.shutdown() to make things easier

Maybe. If so, we would also need a check to avoid calling shutdown if the platform was never started. In this specific case, I know that if the stage is null, then the platform was not started, but the utility method could not make that assumption.

In any case, I would want to do it as a follow-up RFE for the test utility and not part of a simple test exclusion bug fix.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1153#discussion_r1229854371